Skip to content

Remove boolean props from ObjectTypeInternalSlot visitor keys#16615

Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom
nicolo-ribaudo:fix-visitor-ObjectTypeInternalSlot
Jul 5, 2024
Merged

Remove boolean props from ObjectTypeInternalSlot visitor keys#16615
nicolo-ribaudo merged 1 commit intobabel:mainfrom
nicolo-ribaudo:fix-visitor-ObjectTypeInternalSlot

Conversation

@nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

These three properties are booleans, they should not be visited.

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: types labels Jul 5, 2024
@nicolo-ribaudo nicolo-ribaudo changed the title Remove non-node props from ObjectTypeInternalSlot visitor keys Remove boolean props from ObjectTypeInternalSlot visitor keys Jul 5, 2024
@nicolo-ribaudo nicolo-ribaudo merged commit 7cc8d18 into babel:main Jul 5, 2024
@nicolo-ribaudo nicolo-ribaudo deleted the fix-visitor-ObjectTypeInternalSlot branch July 5, 2024 17:38
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants