fix(parser): allow TS declare readonly fields with initializers#14817
Merged
JLHwung merged 1 commit intobabel:mainfrom Jul 31, 2022
Josh-Cena:ambient-readonly-field
Merged
fix(parser): allow TS declare readonly fields with initializers#14817JLHwung merged 1 commit intobabel:mainfrom Josh-Cena:ambient-readonly-field
JLHwung merged 1 commit intobabel:mainfrom
Josh-Cena:ambient-readonly-field
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52659/ |
liuxingbaoyu
approved these changes
Jul 31, 2022
JLHwung
approved these changes
Jul 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns Babel's behavior with microsoft/TypeScript#26313 for class fields. Specifically:
However, this PR does not attempt to mimic the
isInvalidInitializerpart, which checks if the initializer is a string/number literal or an enum reference. Doing so "correctly" would likely require type information. Quoting evanw/esbuild@147163e,Instead, we avoid all errors with
declare readonlythat don't have a type annotation.