chore: expand prettier-e2e test and update typings/deps#14779
chore: expand prettier-e2e test and update typings/deps#14779JLHwung merged 4 commits intobabel:mainfrom
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52614/ |
|
#14723 ( |
| # Only run js,jsx,misc format tests | ||
| # Without --runInBand CircleCI hangs. | ||
| yarn test "tests/format/(jsx?|misc)/" --update-snapshot --runInBand | ||
| yarn test "tests/format/(jsx?|misc|typescript|flow|flow-repo)/" --update-snapshot --maxWorkers=2 |
There was a problem hiding this comment.
We may have to defer this change until prettier updated the snapshot.
There was a problem hiding this comment.
Won't work... I'm fixing that in next branch
There was a problem hiding this comment.
Can you switch to next? We'll focus on this branch for a while. And if you do that --maxWorkers should be removed, because we use --runInBand, have to do that with jest-light-runner.
There was a problem hiding this comment.
I'm worried this will be a little slow.😕
There was a problem hiding this comment.
It's a recoverable exception, it doesn't throw, and ast is generated normally, maybe that has something to do with it?
There was a problem hiding this comment.
Yes, we allow some recoverable error https://github.com/prettier/prettier/blob/ab72a2c11c806f3a8a5ef42314e291843e1b3e68/src/language-js/parse/babel.js#L183, have you changed the message code or throwing a different message code?
There was a problem hiding this comment.
https://github.com/babel/babel/blob/v7.18.9/packages/babel-parser/src/plugins/jsx/index.js#L38-L41
Maybe this? Looks like a new addition.
There was a problem hiding this comment.
Anyway, we can fix that test by disallowing that from recovering( make it invalid ), it's invalid in typescript parser after all.
a5e04e6 to
6fe5cfb
Compare
ad4f09b to
31496cf
Compare
@nicolo-ribaudo Can you take a look at this? I'm not sure how I should update, using |
|
Delete |
|
Oh, thanks! (I didn't think of it at all😂) |
344893e to
2bb785a
Compare
2bb785a to
8354005
Compare
Fixes #1, Fixes #21.#14765 (comment)
2.#13414 (comment)
3.#14777 (comment)
4.#14701 (comment)