fix: TS declare class in namespace should be removed#14774
Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom Jul 20, 2022
Merged
fix: TS declare class in namespace should be removed#14774nicolo-ribaudo merged 3 commits intobabel:mainfrom
declare class in namespace should be removed#14774nicolo-ribaudo merged 3 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52569/ |
f497498 to
afc6949
Compare
afc6949 to
799c0c1
Compare
liuxingbaoyu
approved these changes
Jul 20, 2022
Contributor
Author
Ok,I’d like to do it. |
declare class in namespace should be removed
declare class in namespace should be removeddeclare class in namespace should be removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a concrete example, please see Issue, Declare class in namespace should not be assigned as a value after compilation.
Currently, babel-plugin-transform-typescript does not consider ClassDeclaration as a pure type.