Remove git.io shortlinks from repo#14493
Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom Apr 27, 2022
Andoryuuta:remove-git_io_shortlinks
Merged
Remove git.io shortlinks from repo#14493nicolo-ribaudo merged 2 commits intobabel:mainfrom Andoryuuta:remove-git_io_shortlinks
nicolo-ribaudo merged 2 commits intobabel:mainfrom
Andoryuuta:remove-git_io_shortlinks
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51758/ |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51747/ |
JLHwung
reviewed
Apr 26, 2022
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
Can you replace master to main?
Contributor
Author
|
Sure, I'll update the PR later today. The current URL's are just what the existing git.io links resolved to. |
SukkaW
suggested changes
Apr 27, 2022
| syntax: { | ||
| name: "@babel/plugin-syntax-class-properties", | ||
| url: "https://github.com/babel/babel/tree/master/packages/babel-plugin-syntax-class-properties", | ||
| url: "https://github.com/babel/babel/tree/main/packages/babel-plugin-syntax-class-properties", |
| syntax: { | ||
| name: "@babel/plugin-syntax-class-properties", | ||
| url: "https://github.com/babel/babel/tree/master/packages/babel-plugin-syntax-class-properties", | ||
| url: "https://github.com/babel/babel/tree/main/packages/babel-plugin-syntax-class-properties", |
| syntax: { | ||
| name: "@babel/plugin-syntax-class-properties", | ||
| url: "https://github.com/babel/babel/tree/master/packages/babel-plugin-syntax-class-properties", | ||
| url: "https://github.com/babel/babel/tree/main/packages/babel-plugin-syntax-class-properties", |
JLHwung
approved these changes
Apr 27, 2022
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
The URLs returning 404 are archived plugins, we can fix them in another PR.
nicolo-ribaudo
approved these changes
Apr 27, 2022
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Thanks! I agree, lets get this merged since it's quite urgent. We can iterate and improve the links later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github has deprecated git.io and will be disabling all links on April 29th.
This PR replaces all git.io shortened links with the URL they redirect to.