Skip to content

fix: parse type parameters within correct context#14384

Merged
JLHwung merged 1 commit intobabel:mainfrom
JLHwung:fix-14383
Mar 23, 2022
Merged

fix: parse type parameters within correct context#14384
JLHwung merged 1 commit intobabel:mainfrom
JLHwung:fix-14383

Conversation

@JLHwung
Copy link
Copy Markdown
Contributor

@JLHwung JLHwung commented Mar 23, 2022

Q                       A
Fixed Issues? Fixes #14383
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The tsTryParseTypeParameters should run within state.inType so that the >= in type T<U>=U will be correctly tokenized as tt.gt and tt.eq.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser area: typescript labels Mar 23, 2022
@babel-bot
Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51545/

@JLHwung JLHwung merged commit 326c420 into babel:main Mar 23, 2022
@JLHwung JLHwung deleted the fix-14383 branch March 23, 2022 20:10
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: @babel/generator parse error with the typescript when enable the compact opts

4 participants