Align named imports behavior in .mjs and .js files#14366
Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom Mar 22, 2022
Merged
Align named imports behavior in .mjs and .js files#14366nicolo-ribaudo merged 2 commits intobabel:mainfrom
.mjs and .js files#14366nicolo-ribaudo merged 2 commits intobabel:mainfrom
Conversation
nicolo-ribaudo
commented
Mar 17, 2022
| @@ -1,5 +1,5 @@ | |||
| // No exception should be thrown | |||
Member
Author
There was a problem hiding this comment.
File renamed because our runner doesn't actually run exec.mjs files.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51496/ |
JLHwung
approved these changes
Mar 18, 2022
existentialism
approved these changes
Mar 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new behavior of defaulting to
falseis compatible with the old one, because it's strictly additive. When importing withimport * as nsa file that exportsmodule.exports = { foo: 1 }from an mjs file, the previous value ofnswas{ default: { foo: 1 } }and now it will be{ default: { foo: 1 }, foo: 1 }.This aligns the
.mjsbehavior with what we do in.jsfiles, and with what Node.js does.In Babel 8 we will remove
mjsStrictNamespaceoption. We should probably also removestrictNamespace, now that Node.js doesn't have that behavior anymore.