Allow variable and function with the same name in static blocks#14344
Merged
JLHwung merged 10 commits intobabel:mainfrom Mar 10, 2022
Merged
Allow variable and function with the same name in static blocks#14344JLHwung merged 10 commits intobabel:mainfrom
JLHwung merged 10 commits intobabel:mainfrom
Conversation
…claration in class static block babel#14257
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51459/ |
Contributor
Author
|
I wonder why babel bot shows another issue (not about static block) in REPL... |
Member
|
You can edit the REPL contents to whatever you want 😉 |
nicolo-ribaudo
approved these changes
Mar 9, 2022
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
The CI failure is not related to this PR, it's a flaky test that sometimes fails.
JLHwung
reviewed
Mar 10, 2022
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
static block is an ES2022 feature, can you move the test case to es2022? There is a static block folder over there. I think it suffices to add only one test case.
Contributor
Author
|
I have created a new subdirectory: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow a variable and a function to have a same name in a static block