Fix import type/typeof printing with no specifiers#14309
Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom Feb 28, 2022
Merged
Fix import type/typeof printing with no specifiers#14309nicolo-ribaudo merged 2 commits intobabel:mainfrom
import type/typeof printing with no specifiers#14309nicolo-ribaudo merged 2 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51374/ |
import type/typeof printing with no specifiers
db31329 to
4fd02b8
Compare
nicolo-ribaudo
approved these changes
Feb 27, 2022
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Thanks! I rebased to fix the CI failure and pushed a commit to deduplicate some code (keeping the logic you implemented: it was correct, but two branches could be merged).
existentialism
approved these changes
Feb 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty braces will still be printed even if the there are no specifers, check added for importKind, empty braces will be printed on type and typeof imports.