Skip to content

fix(babel-parser): Allow line break before assert return type#13771

Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom
JuniorTour:fix-13761
Sep 16, 2021
Merged

fix(babel-parser): Allow line break before assert return type#13771
nicolo-ribaudo merged 1 commit intobabel:mainfrom
JuniorTour:fix-13761

Conversation

@JuniorTour
Copy link
Copy Markdown
Contributor

@JuniorTour JuniorTour commented Sep 16, 2021 •
edited
Loading

Q                       A
Fixed Issues? Fix #13761
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link No
Any Dependency Changes? No
License MIT

Remove this.hasPrecedingLineBreak() to allow use line break before Typescript function assertion.

Avoid throw Error for Babel playground example.

Remain consistent with Typescript playground behavior.

Before Fix After Fix
Screenshot 46fc4e1f0589fd91212e8eeb71a0c16 998e1169cfa19c86e2cac499a56e941

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Sep 16, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48756/

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Sep 16, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b7bbb74:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@fedeci fedeci added area: typescript pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Sep 16, 2021
@fedeci fedeci changed the title fix(babel-parser): parse typescript function assertion with line break throw error (fix #13761) fix(babel-parser): parse typescript function assertion with line break throw error Sep 16, 2021
fedeci
fedeci approved these changes Sep 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

nicolo-ribaudo
nicolo-ribaudo approved these changes Sep 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nicolo-ribaudo nicolo-ribaudo changed the title fix(babel-parser): parse typescript function assertion with line break throw error fix(babel-parser): Allow line break before assert return type Sep 16, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit da79c90 into babel:main Sep 16, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@fedeci fedeci fedeci approved these changes

Assignees

No one assigned

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: error parsing typescript assertion signature

4 participants

@JuniorTour @babel-bot @nicolo-ribaudo @fedeci