[estree] Fix conversion of PrivateName in MemberExpression#13755
Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom Sep 14, 2021
Merged
[estree] Fix conversion of PrivateName in MemberExpression#13755nicolo-ribaudo merged 2 commits intobabel:mainfrom
PrivateName in MemberExpression#13755nicolo-ribaudo merged 2 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48701/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c6f3500:
|
JLHwung
approved these changes
Sep 13, 2021
fedeci
approved these changes
Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit updates the test and has a wrong output; the second commit fixes it.
The reason of the bug was that when parsing member expressions we don't call
maybeParsePrivateName, but justparsePrivateName.