chore: add constraint for duplicate dependency declarations#13744
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom Sep 10, 2021
Merged
chore: add constraint for duplicate dependency declarations#13744nicolo-ribaudo merged 1 commit intobabel:mainfrom
nicolo-ribaudo merged 1 commit intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48615/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 251abb8:
|
JLHwung
approved these changes
Sep 10, 2021
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
We can apply the constraints to (peerDependencies, dependencies) too.
existentialism
approved these changes
Sep 10, 2021
Contributor
Author
|
@JLHwung That's actually a valid pattern, Yarn will use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a constraint to enforce the change in #13737, while it doesn't cause issues in published packages since
devDependenciesare ignored, it can cause an issue in the monorepo sincedevDependencieswins when a dependency is declared in bothdependenciesanddevDependencies.