fix: pass browserslistEnv to resolveTargets#13697
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom Aug 30, 2021
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48313/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b8b67ba:
|
JLHwung
reviewed
Aug 20, 2021
...ages/babel-helper-compilation-targets/test/browserslist-extends/browserslist-extends.spec.js
Outdated
Show resolved
Hide resolved
62eb2f1 to
a84b13a
Compare
JLHwung
reviewed
Aug 23, 2021
a84b13a to
b8b67ba
Compare
nicolo-ribaudo
approved these changes
Aug 30, 2021
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Thank you!
I usually ask to not commit changes to .gitignore since you can use .git/info/exclude instead. However, since this also needs change in the Jest config and since that extension looks useful (I might use it!), it's ok this time.
browserslistEnv to resolveTargets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of explicitly specifying browserslist query with
extendskeyword,browserslistEnvoption was not passed to browserslist itself leading to wrong resolved targets