Disallow reinitializing private elements by komyg · Pull Request #13601 · babel/babel

komyg · 2021-07-26T22:38:37Z

Q	A
Fixed Issues?	Fixes #13299
Patch: Bug Fix
Major: Breaking Change?	No
Minor: New Feature?	No
Tests Added + Pass?	No
Documentation PR Link
Any Dependency Changes?	No
License	MIT

babel-bot · 2021-07-26T22:43:00Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48244/

codesandbox-ci · 2021-07-26T22:43:25Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ebf193c:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

packages/babel-helper-create-class-features-plugin/src/fields.ts

packages/babel-helpers/src/helpers.js

colinaaa · 2021-08-03T04:43:16Z

Since #13570 has been merged, you probably need to rebase to main and write code with typings

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

…into fix/bug-13299-class-members

komyg · 2021-08-05T13:48:25Z

Since #13570 has been merged, you probably need to rebase to main and write code with typings

Done!

Thank you for the typings by the way. They will be very hepful.

packages/babel-helper-create-class-features-plugin/src/fields.ts

nicolo-ribaudo · 2021-08-07T17:45:42Z

Can you run OVERWRITE=true yarn jest or OVERWRITE=true make test?

komyg · 2021-08-07T18:00:18Z

Can you run OVERWRITE=true yarn jest or OVERWRITE=true make test?

Done.

I've pushed all the snapshot changes.

packages/babel-helpers/src/helpers.js

nicolo-ribaudo · 2021-08-11T18:16:19Z

The CI failure would be fixed by rebasing; don't worry about it.

nicolo-ribaudo

Thanks!

packages/babel-helper-create-class-features-plugin/src/fields.ts

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

packages/babel-helper-create-class-features-plugin/src/fields.ts

Co-authored-by: Justin Ridgewell <justin@ridgewell.name>

komyg · 2021-08-18T11:18:06Z

Hi @nicolo-ribaudo, @jridgewell, @JLHwung and @colinaaa, I've incorporated all of your suggestions and added the latest changes from the main branch.

Would you like to re-review it?

jridgewell

LGTM, thanks for working on this!

nicolo-ribaudo

Thank you!

komyg added 3 commits July 19, 2021 11:33

Reproduced error for member properties

d909242

Fixed tests

5d643dd

Added private fields check

53e82d8

komyg changed the title ~~Fix/bug 13299 class members~~ Fix 13299 Jul 26, 2021

komyg mentioned this pull request Jul 26, 2021

[Bug]: Class Private Fields/Accessors/Methods must not be re-initialized on instance #13299

Closed

1 task

jridgewell changed the title ~~Fix 13299~~ Fix reinitialized private field Jul 26, 2021

nicolo-ribaudo added PR: Spec Compliance 👓 A type of pull request used for our changelog categories Spec: Class Fields labels Jul 26, 2021

komyg added 4 commits July 28, 2021 08:22

Updated field initializtion

9ecbcf3

Updated helpers

90f39e5

Added helper call

ce05c09

Fixed unit test

06300db

nicolo-ribaudo reviewed Jul 30, 2021

View reviewed changes

packages/babel-helper-create-class-features-plugin/src/fields.ts Outdated Show resolved Hide resolved

komyg added 5 commits August 2, 2021 08:53

Removed commented code

0f5a4e7

Handle unavailable helper

086c12d

Updated error statement

a975111

Updated error text

454c2cc

Added private method helper

dbc25c4

nicolo-ribaudo reviewed Aug 2, 2021

View reviewed changes

packages/babel-helper-create-class-features-plugin/src/fields.ts Outdated Show resolved Hide resolved

packages/babel-helpers/src/helpers.js Outdated Show resolved Hide resolved

packages/babel-helpers/src/helpers.js Outdated Show resolved Hide resolved

komyg and others added 5 commits August 5, 2021 10:20

Update packages/babel-helpers/src/helpers.js

5770b46

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

Added babel 8 breaking guard

2e6f07a

Merge branch 'fix/bug-13299-class-members' of github.com:komyg/babel …

2d6c4a2

…into fix/bug-13299-class-members

Merge branch 'main' into fix/bug-13299-class-members

aa4677d

Fixed typings error

13f8014

nicolo-ribaudo reviewed Aug 5, 2021

View reviewed changes

packages/babel-helper-create-class-features-plugin/src/fields.ts Outdated Show resolved Hide resolved

nicolo-ribaudo reviewed Aug 5, 2021

View reviewed changes

packages/babel-helper-create-class-features-plugin/src/fields.ts Outdated Show resolved Hide resolved

Handle private accessor method

c275da7

Overwritten tests

01e2e0b

nicolo-ribaudo reviewed Aug 11, 2021

View reviewed changes

packages/babel-helpers/src/helpers.js Outdated Show resolved Hide resolved

Updated error message

4047989

komyg marked this pull request as ready for review August 12, 2021 16:42

komyg requested a review from nicolo-ribaudo August 16, 2021 11:30

nicolo-ribaudo approved these changes Aug 16, 2021

View reviewed changes

packages/babel-helper-create-class-features-plugin/src/fields.ts Outdated Show resolved Hide resolved

packages/babel-helper-create-class-features-plugin/src/fields.ts Outdated Show resolved Hide resolved

komyg and others added 3 commits August 16, 2021 17:52

Update packages/babel-helper-create-class-features-plugin/src/fields.ts

8e5e404

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

Update packages/babel-helper-create-class-features-plugin/src/fields.ts

1f6b26c

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

Merge branch 'main' into fix/bug-13299-class-members

eca092f

jridgewell approved these changes Aug 17, 2021

View reviewed changes

JLHwung approved these changes Aug 18, 2021

View reviewed changes

komyg and others added 4 commits August 18, 2021 07:12

Update packages/babel-helper-create-class-features-plugin/src/fields.ts

d187a77

Co-authored-by: Justin Ridgewell <justin@ridgewell.name>

Update packages/babel-helper-create-class-features-plugin/src/fields.ts

1d33cf2

Co-authored-by: Justin Ridgewell <justin@ridgewell.name>

Update packages/babel-helper-create-class-features-plugin/src/fields.ts

f9eb76a

Co-authored-by: Justin Ridgewell <justin@ridgewell.name>

Clone id nodes

ebf193c

komyg requested review from JLHwung, jridgewell and nicolo-ribaudo August 18, 2021 11:16

jridgewell approved these changes Aug 18, 2021

View reviewed changes

nicolo-ribaudo approved these changes Aug 30, 2021

View reviewed changes

nicolo-ribaudo changed the title ~~Fix reinitialized private field~~ Disallow reinitializing private elements Aug 30, 2021

nicolo-ribaudo merged commit fdfe978 into babel:main Aug 30, 2021

komyg deleted the fix/bug-13299-class-members branch August 30, 2021 11:16

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 30, 2021

github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2021

Uh oh!

Conversation

komyg commented Jul 26, 2021 • edited by nicolo-ribaudo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

babel-bot commented Jul 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codesandbox-ci bot commented Jul 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

colinaaa commented Aug 3, 2021

Uh oh!

komyg commented Aug 5, 2021

Uh oh!

Uh oh!

Uh oh!

nicolo-ribaudo commented Aug 7, 2021

Uh oh!

komyg commented Aug 7, 2021

Uh oh!

Uh oh!

nicolo-ribaudo commented Aug 11, 2021

Uh oh!

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

komyg commented Aug 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jridgewell left a comment

Choose a reason for hiding this comment

Uh oh!

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

komyg commented Jul 26, 2021 •

edited by nicolo-ribaudo

Loading

babel-bot commented Jul 26, 2021 •

edited

Loading

codesandbox-ci bot commented Jul 26, 2021 •

edited

Loading

komyg commented Aug 18, 2021 •

edited

Loading