fix(babel-types): accept UnaryExpression in TSLiteralType#13525
Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom Jul 2, 2021
colinaaa:fix/ts-literal-type
Merged
fix(babel-types): accept UnaryExpression in TSLiteralType#13525nicolo-ribaudo merged 3 commits intobabel:mainfrom colinaaa:fix/ts-literal-type
UnaryExpression in TSLiteralType#13525nicolo-ribaudo merged 3 commits intobabel:mainfrom
colinaaa:fix/ts-literal-type
Conversation
…ession seems that the generated files is missing typings fix #13327
colinaaa
commented
Jul 2, 2021
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47181/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9c5a677:
|
now generated types seems correct
colinaaa
commented
Jul 2, 2021
existentialism
approved these changes
Jul 2, 2021
UnaryExpression in TSLiteralType
nicolo-ribaudo
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Jul 30, 2021
…13525) * fix(babel-types): add validator for TSLiteralType to accept UnaryExpression seems that the generated files is missing typings fix babel#13327 * fix(babel-types): add allowlist for TSLiteralType now generated types seems correct * fix(babel-types): use oneOfNodeTypes instead of oneOf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validator for
TSLiteralTypeto acceptUnaryExpressioneg: