Fix config validation message typo#13515
Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom Jun 29, 2021
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47135/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b8d5987:
|
| }] | ||
| ] | ||
| To be a valid preset, its name and options should be wrapped in a pair of brackets" | ||
| To be a valid presets, its name and options should be wrapped in a pair of brackets" |
Member
There was a problem hiding this comment.
Actually, it's better not to have the s here. Maybe you could edit the checkNoUnwrappedItemOptionPairs adding the s for the "Maybe you meant to use" section, rather than changing it in the parameter?
Contributor
Author
There was a problem hiding this comment.
good point!
I fixed it as you said.
existentialism
approved these changes
Jun 29, 2021
nicolo-ribaudo
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Jul 30, 2021
* Fix config validation message typo * Fix `checkNoUnwrappedItemOptionPairs` type param
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed config option names in validation message
preset/plugin->presets/plugins.