Add typeParameters to tagged template visitor keys#13500
Merged
JLHwung merged 4 commits intobabel:mainfrom Jun 22, 2021
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47055/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0db9957:
|
nicolo-ribaudo
previously approved these changes
Jun 22, 2021
Uh it looks like I was wrong, it's builder that inherits from visitor and visitor defaults to an empty array 😅
3e7c299 to
c080d9e
Compare
JLHwung
commented
Jun 22, 2021
| }); | ||
|
|
||
| defineType("ClassPrivateProperty", { | ||
| visitor: ["key", "value", "decorators", "typeAnnotation"], |
Contributor
Author
There was a problem hiding this comment.
Added "typeAnnotation" to visitor keys.
nicolo-ribaudo
approved these changes
Jun 22, 2021
existentialism
approved these changes
Jun 22, 2021
nicolo-ribaudo
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Jul 30, 2021
* refactor: move ES2022 AST nodes to core * fix: add typeParameters to visitor keys * chore: update artifacts * fix: add typeAnnotation to visitor keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.