fix: throw when async() call param is object with assignement#13410
Merged
nicolo-ribaudo merged 6 commits intobabel:mainfrom Jun 3, 2021
Merged
Conversation
…ttern in async call
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46657/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1183a3c:
|
JLHwung
reviewed
Jun 2, 2021
JLHwung
reviewed
Jun 2, 2021
JLHwung
reviewed
Jun 2, 2021
JLHwung
reviewed
Jun 3, 2021
JLHwung
reviewed
Jun 3, 2021
JLHwung
approved these changes
Jun 3, 2021
async() call param is object with assignement
fisker
added a commit
to prettier/prettier
that referenced
this pull request
Jun 13, 2021
fisker
added a commit
to prettier/prettier
that referenced
this pull request
Jun 13, 2021
This was referenced Jun 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there 👋 ,
After few hours exploring
babel-parserI open this draft pull request.Let me know what do you think about the code.
Input code:
Before: was parsed without error 🤮
After: throw an error as expected 🎉
Note: I got an error running all tests
But it seems to be there even on
mainbranch .