Relax import assertion key-is-type constraint#13409
Merged
JLHwung merged 4 commits intobabel:mainfrom Jun 2, 2021
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46622/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 752602e:
|
JLHwung
commented
Jun 1, 2021
| if (keyName !== "type") { | ||
| this.raise( | ||
| node.key.start, | ||
| Errors.ModuleAttributeDifferentFromType, |
Contributor
Author
There was a problem hiding this comment.
Note that we can not remove ModuleAttributeDifferentFromType from Error templates because it is still used in parseModuleAttributes.
nicolo-ribaudo
previously approved these changes
Jun 2, 2021
Whops, I looked at the code without looking at CI
39a0c52 to
752602e
Compare
existentialism
approved these changes
Jun 2, 2021
nicolo-ribaudo
approved these changes
Jun 2, 2021
This was referenced Jun 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relaxes previously implemented constraint that the AssertionKey must be of string value
"type". Note that babel parser also supportsmoduleAttributes, a legacy version ofimportAssertionswhich shares similar behaviour. The behaviour inmoduleAttributesis not changed as the plugin is deprecated and will be removed in Babel 8./cc @xtuc