fix generate-helpers failing in URL-encoded path#13404
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom May 31, 2021
Merged
fix generate-helpers failing in URL-encoded path#13404nicolo-ribaudo merged 1 commit intobabel:mainfrom
nicolo-ribaudo merged 1 commit intobabel:mainfrom
Conversation
HELPERS_FOLDER.pathname may be URL-encoded, if the working tree's absolute path contains spaces, some reserved characters, or anything beyond ASCII. readFile accepts a plain String or URL for the path, but does not automatically decode URL-encoded Strings.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46583/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4871fa4:
|
nicolo-ribaudo
approved these changes
May 31, 2021
This was referenced Jun 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make buildfails if your working tree is inside a directory with some non-ASCII characters along the path (or spaces, or certain reserved characters, like%or#). Example output:This PR decodes the URL-encoded pathname before passing it to
readFile.I don't know how I would write a test for this, because the bug doesn't manifest unless you have the repository checked out under a path containing spaces, for example.