[babel-types] Update matchesPattern to account for this#13264
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom May 5, 2021
Merged
[babel-types] Update matchesPattern to account for this#13264nicolo-ribaudo merged 1 commit intobabel:mainfrom
matchesPattern to account for this#13264nicolo-ribaudo merged 1 commit intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45840/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e456654:
|
jridgewell
approved these changes
May 5, 2021
nicolo-ribaudo
approved these changes
May 5, 2021
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Thanks, I have already been hit by this multiple times! 😬
matchesPattern to account for this
This was referenced May 18, 2021
This was referenced May 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matchesPatterndoes not currently work for expressions that containthisI had noticed that
matchesPatterncurrently does not work for MemberExpressions that containthis. This PR addresses the issue by adding a check forisThisExpression(node).I'm not sure if this was excluded on purpose, but the change was simple so I figured I'd throw up a PR really quick. Also added a test case for the fix.