Set exprAllowed to false for star token#11449
Merged
existentialism merged 1 commit intomasterfrom Apr 21, 2020
Merged
Conversation
Member
existentialism
commented
Apr 20, 2020
| Q | A |
|---|---|
| Fixed Issues? | Fixes #11435 |
| Patch: Bug Fix? | Y |
| Major: Breaking Change? | N |
| Minor: New Feature? | N |
| Tests Added + Pass? | Y/Y |
| License | MIT |
Member
|
Do we have a test for |
Member
Author
|
@nicolo-ribaudo added some, couldn't find any |
1ccff7e to
88cf427
Compare
JLHwung
approved these changes
Apr 20, 2020
88cf427 to
98f28ea
Compare
98f28ea to
3a761e6
Compare
Member
|
@existentialism Could you update the flow tests whitelist file? https://github.com/facebook/flow/blob/master/src/parser/test/flow/async_generators/migrated_0007.js isn't failing anymore. |
Member
Author
|
@nicolo-ribaudo good catch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.