Skip to content

chore: upgrade @babel/* deps#11422

Merged
nicolo-ribaudo merged 2 commits intobabel:masterfrom
JLHwung:update-babel-deps
Apr 15, 2020
Merged

chore: upgrade @babel/* deps#11422
nicolo-ribaudo merged 2 commits intobabel:masterfrom
JLHwung:update-babel-deps

Conversation

@JLHwung
Copy link
Copy Markdown
Contributor

@JLHwung JLHwung commented Apr 14, 2020

Q                       A
Fixed Issues? Per nodejs/node#32852 (comment)
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? Update @babel/* dev deps.
License MIT

@JLHwung JLHwung added PR: Internal 🏠 A type of pull request used for our changelog categories PR: Fixes failing main labels Apr 14, 2020
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove code to make things work ✔️

@hzoo
Copy link
Copy Markdown
Member

hzoo commented Apr 15, 2020

Guess should update ourselves every minor at least haha, although we have the smoke test for master?

@nicolo-ribaudo
Copy link
Copy Markdown
Member

The smoke tests didn't catch it because it's a Node.js breaking change, not something that we control.

@nicolo-ribaudo nicolo-ribaudo merged commit c85aafd into babel:master Apr 15, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the update-babel-deps branch April 15, 2020 14:57
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Fixes failing main PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants