[@babel/cli] Copy ignored files by default#11063
Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom Jan 30, 2020
Merged
Conversation
This commit restores the pre-7.8.0 behavior of the --copy-files option, by making --copy-ignored default to true when --copy-files is enabled.
existentialism
approved these changes
Jan 29, 2020
kaicataldo
approved these changes
Jan 29, 2020
Member
kaicataldo
left a comment
There was a problem hiding this comment.
LGTM! The negative flag feels a little strange to me, but I don't have a better suggestion 🤷♂️
Member
Author
|
@kaicataldo We also have other |
Contributor
|
Great. We can fix #11052 (comment) separately. 👍 |
rajasekarm
pushed a commit
to rajasekarm/babel
that referenced
this pull request
Feb 17, 2020
This commit restores the pre-7.8.0 behavior of the --copy-files option, by making --copy-ignored default to true when --copy-files is enabled.
This was referenced Feb 24, 2020
This was referenced Mar 7, 2020
This was referenced Mar 14, 2020
This was referenced Mar 26, 2020
This was referenced Apr 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit restores the pre-7.8.0 behavior of the
--copy-filesoption, by making--copy-ignoreddefault to true when--copy-filesis enabled.@serhalp Could you check if the
--copy-filestests in https://github.com/nicolo-ribaudo/babel/tree/regression-7.8-cli/packages/babel-cli/test/fixtures/babel match your expectations?@STRML I didn't take a look at the other bug you mentioned in #11052