Re-generate preset-env fixtures#11016
Merged
JLHwung merged 3 commits intobabel:masterfrom Jan 16, 2020
Merged
Conversation
Member
Author
|
Oh nevermind, |
Member
Author
|
This is not safe, I'll investigate |
bfa4f6d to
a6c8c64
Compare
a6c8c64 to
0efeb52
Compare
Member
Author
|
Ok now it looks ok: |
JLHwung
reviewed
Jan 16, 2020
| "proposal-async-generator-functions": "Asynchronous Iterators", | ||
| "proposal-object-rest-spread": "object rest/spread properties", | ||
|
|
||
| // We want to apply this prior to unicode regex so that "." and "u" |
Contributor
There was a problem hiding this comment.
I don't think the order of regex-related plugins still matters since they are essentially feature flags now, the regexpu-core should only run once for every applicable regex.
JLHwung
reviewed
Jan 16, 2020
| "proposal-optional-catch-binding": "optional catch binding", | ||
| "proposal-optional-chaining": "optional chaining operator (?.)", | ||
| "proposal-unicode-property-regex": "RegExp Unicode Property Escapes", | ||
| const es5 = { |
Contributor
There was a problem hiding this comment.
Would be good to add a comment here if the key order will impact the plugin execution order of preset-env.
JLHwung
approved these changes
Jan 16, 2020
existentialism
approved these changes
Jan 16, 2020
Member
existentialism
left a comment
There was a problem hiding this comment.
I coulda swore I had a comment about keeping order of the data, but I guess not ¯_(ツ)_/¯
This was referenced Feb 24, 2020
This was referenced Mar 7, 2020
This was referenced Mar 25, 2020
This was referenced Apr 2, 2020
This was referenced Apr 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should only re-order the logged plugins. I don't know why GitHub shows more created lines than deleted, but locally the match: