Skip to content

Archive syntax plugins enabled by default#10820

Merged
nicolo-ribaudo merged 4 commits intobabel:masterfrom
nicolo-ribaudo:syntax-default-archived
Jan 12, 2020
Merged

Archive syntax plugins enabled by default#10820
nicolo-ribaudo merged 4 commits intobabel:masterfrom
nicolo-ribaudo:syntax-default-archived

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Member

Q                       A
License MIT

Moved to babel-archive: babel/babel-archive@8f23ddc

  • @babel/plugin-syntax-async-generators
  • @babel/plugin-syntax-bigint
  • @babel/plugin-syntax-dynamic-import
  • @babel/plugin-syntax-json-strings
  • @babel/plugin-syntax-nullish-coalescing-operator
  • @babel/plugin-syntax-object-rest-spread
  • @babel/plugin-syntax-optional-catch-binding
  • @babel/plugin-syntax-optional-chaining

@nicolo-ribaudo nicolo-ribaudo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Dec 5, 2019
@nicolo-ribaudo
Copy link
Copy Markdown
Member Author

This PR depends on all the PRs that are enabling some syntax by default in the parser

@nicolo-ribaudo nicolo-ribaudo force-pushed the syntax-default-archived branch 4 times, most recently from 30899e7 to b15ccff Compare January 10, 2020 22:44
@nicolo-ribaudo nicolo-ribaudo changed the title Remove syntax plugins enabled by default Archive syntax plugins enabled by default Jan 10, 2020
Moved to babel-archive: babel/babel-archive@8f23ddc

- `@babel/plugin-syntax-async-generators`
- `@babel/plugin-syntax-bigint`
- `@babel/plugin-syntax-dynamic-import`
- `@babel/plugin-syntax-json-strings`
- `@babel/plugin-syntax-nullish-coalescing-operator`
- `@babel/plugin-syntax-object-rest-spread`
- `@babel/plugin-syntax-optional-catch-binding`
- `@babel/plugin-syntax-optional-chaining`
@nicolo-ribaudo nicolo-ribaudo force-pushed the syntax-default-archived branch from b15ccff to cb1b272 Compare January 12, 2020 23:21
@nicolo-ribaudo nicolo-ribaudo merged commit a677d59 into babel:master Jan 12, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the syntax-default-archived branch January 12, 2020 23:31
@Alonski
Copy link
Copy Markdown

Alonski commented Jan 14, 2020

Hmm wondering why this wasn't a breaking change. 🤔
Had to install all of these one by one until build passed

@nicolo-ribaudo
Copy link
Copy Markdown
Member Author

nicolo-ribaudo commented Jan 14, 2020

With Babel 7.8 you don't need to install them. Maybe you were accidentally using an older Babel version, which required them.

Can you share a repository which reproduces the issue?

@Alonski
Copy link
Copy Markdown

Alonski commented Jan 14, 2020

Hmm it is on a private app that I can't share. I just upgraded from 7.8.0 to 7.8.3 and started seeing compile time errors. Weird I know :)

@nicolo-ribaudo
Copy link
Copy Markdown
Member Author

Also, this PR only changes tests and moves some packages to a different repository. It doesn't change the contents of any published package 🤔

@Alonski
Copy link
Copy Markdown

Alonski commented Jan 14, 2020

Hmm maybe it's not this PR then. 😅 I'll check again tomorrow and jump minors one by one

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 15, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants