Flow enums: fix enum body location#10737
Merged
existentialism merged 2 commits intobabel:masterfrom Nov 20, 2019
gkz:flow-enums-locs-fix
Merged
Flow enums: fix enum body location#10737existentialism merged 2 commits intobabel:masterfrom gkz:flow-enums-locs-fix
existentialism merged 2 commits intobabel:masterfrom
gkz:flow-enums-locs-fix
Conversation
nicolo-ribaudo
approved these changes
Nov 19, 2019
Member
|
(Please run |
Member
|
@gkz thanks! |
This was referenced Dec 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The location of the Flow enum bodys was incorrect. I fixed this in flow-parser (facebook/flow@498a209), and this PR fixes this in Babel, making it consistent with flow-parser, and also consistent with what the enum body contains (everything after
enum E).The diff also does some minor refactoring and cleaning up:
flowEnumBodyfunction.This incorrect location was discovering when adding support in Prettier prettier/prettier#6860
After this lands and they update their parser deps, Prettier can remove their hacks.