Babel should not silently remove unknown options after commander arguments#10698
Merged
nicolo-ribaudo merged 3 commits intobabel:masterfrom Nov 12, 2019
Merged
Babel should not silently remove unknown options after commander arguments#10698nicolo-ribaudo merged 3 commits intobabel:masterfrom
nicolo-ribaudo merged 3 commits intobabel:masterfrom
Conversation
existentialism
approved these changes
Nov 12, 2019
nicolo-ribaudo
approved these changes
Nov 12, 2019
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Commander is only officially supported on Node 8 and above, and requires Node 6
It should be fine since we will drop Node 6 and 8 soon, too. If CI is good we may say it should work on Node 6 from now on.
Ok since CI is passing, but we should be ready to pin an exact version in the future if it stops working.
This was referenced Dec 5, 2019
This was referenced Dec 12, 2019
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commander.jsis bumped to v4.0.1In this PR we bump
commander.jsto v4.0.1, which can throw on unknown options after arguments when an action handler is provided. To do so we register an empty action handler so that unknown options error can be thrown.Impact analysis of upgrading
commander.jsfrom 2.8 to 4.0Breaking changes from 2.0 to 3.0
Not related
Not related since we are not using custom event listeners
Not related since we don't have any option that has both
--no-and--prefixes.Breaking changes from 3.0 to 4.0
Not related since we are not using the command object in an action handler
It should be fine since we will drop Node 6 and 8 soon, too. If CI is good we may say it should work on Node 6 from now on.
Not related since I can't find any
.args.lengthusage in our codebase.