Parse arrows with params annotations in conditional expressions#10669
Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom Nov 6, 2019
Merged
Conversation
Member
nicolo-ribaudo
commented
Nov 6, 2019
| Q | A |
|---|---|
| Fixed Issues? | Fixes #10651 |
| Patch: Bug Fix? | Yes |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
JLHwung
reviewed
Nov 6, 2019
| @@ -0,0 +1,2 @@ | |||
| test | |||
| ? (x: T): U => y | |||
Contributor
There was a problem hiding this comment.
U => y must be parenthesized, otherwise flow could not parse it.
Member
Author
There was a problem hiding this comment.
It is a known bug with flow, because it also rejects this valid JS code:
test ? (x) : I => y
Member
Author
There was a problem hiding this comment.
For context, here is one of my first PRs 😛
babel/babylon#573
JLHwung
approved these changes
Nov 6, 2019
This was referenced Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.