Skip to content

fix: add inList setter for compatibility with babel-minify#10656

Merged
JLHwung merged 1 commit intobabel:masterfrom
JLHwung:fix-10654
Nov 5, 2019
Merged

fix: add inList setter for compatibility with babel-minify#10656
JLHwung merged 1 commit intobabel:masterfrom
JLHwung:fix-10654

Conversation

@JLHwung
Copy link
Copy Markdown
Contributor

@JLHwung JLHwung commented Nov 5, 2019

Q                       A
Fixed Issues? Fixes #10654
Patch: Bug Fix? Yes
Tests Added + Pass? Nope
Documentation PR Link
Any Dependency Changes?
License MIT

Ultimately we should deprecate manipulating inList. A compatibility setter is offered for inList = false usage in babel-minify.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: traverse labels Nov 5, 2019
@JLHwung JLHwung merged commit 0f94999 into babel:master Nov 5, 2019
@JLHwung JLHwung deleted the fix-10654 branch November 5, 2019 17:28
@CarterLi
Copy link
Copy Markdown

CarterLi commented Nov 6, 2019

I'm encountering this issue. Hopefully a bugfix version will be released soon

@ksegal
Copy link
Copy Markdown

ksegal commented Nov 6, 2019

Thanks for this patch @JLHwung! I was encountering the same errors for a babel project serving a storybook which surfaced a nested storybook ui (see screenshot here), so for now I downgraded babel versions until this fix is out in a release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Babel-minify throws cannot set property inList of [object Object] which has only a getter

5 participants