Skip to content

bump @babel/* dev dependencies#10648

Merged
nicolo-ribaudo merged 4 commits intobabel:masterfrom
JLHwung:dog-fooding
Nov 12, 2019
Merged

bump @babel/* dev dependencies#10648
nicolo-ribaudo merged 4 commits intobabel:masterfrom
JLHwung:dog-fooding

Conversation

@JLHwung
Copy link
Copy Markdown
Contributor

@JLHwung JLHwung commented Nov 5, 2019

Q                       A
Tests Added + Pass? Yes
Any Dependency Changes? Bump dev dependencies.
License MIT

Bump @babel/* devDependencies to 7.7.0, after that the yarn.lock is processed by yarn-deduplicate.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Nov 5, 2019
@existentialism
Copy link
Copy Markdown
Member

Do we need to bump the version value in our transform-runtime config?

@JLHwung
Copy link
Copy Markdown
Contributor Author

JLHwung commented Nov 5, 2019

@existentialism Good point! I am shot by footgun.

Let's wait for the 7.7.2 release and I will update again afterwards.

Note: the size change comes from isIdentifierName introduced at 7.7.0 and interopRequireWildcard helper change.

@buildsize
Copy link
Copy Markdown

buildsize bot commented Nov 5, 2019

File name Previous Size New Size Change
babel-preset-env.js 2.78 MB 2.78 MB 4.68 KB (0%)
babel-preset-env.min.js 1.67 MB 1.68 MB 3.22 KB (0%)
babel.js 2.96 MB 2.96 MB 5.91 KB (0%)
babel.min.js 1.63 MB 1.63 MB 4.1 KB (0%)
test262.tap 4.84 MB [deleted]

? ["@babel/transform-runtime", { version: "7.4.4" }]
? [
"@babel/transform-runtime",
{ version: require("@babel/runtime/package").version },
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this option is not effective until #10668 is merged, because we are always building against the lib version of @babel/*, which has inlined all the helper imports.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants