Fix parentheses on replaceWithMultiple for JSX#10598
Merged
nicolo-ribaudo merged 3 commits intobabel:masterfrom Nov 11, 2019
Merged
Fix parentheses on replaceWithMultiple for JSX#10598nicolo-ribaudo merged 3 commits intobabel:masterfrom
nicolo-ribaudo merged 3 commits intobabel:masterfrom
Conversation
nicolo-ribaudo
approved these changes
Oct 25, 2019
Member
|
CircleCI failure is not related to this PR |
| }); | ||
| }); | ||
| describe("replaceWithMultiple", () => { | ||
| it("ReplaceWithMultiple for a JSXElement with a JSXElement parent", () => { |
Member
There was a problem hiding this comment.
Suggested change
| it("ReplaceWithMultiple for a JSXElement with a JSXElement parent", () => { | |
| it("does not add extra parenthesis for a JSXElement with a JSXElement parent", () => { |
existentialism
approved these changes
Oct 31, 2019
Member
existentialism
left a comment
There was a problem hiding this comment.
One small nit, otherwise LGTM!
JLHwung
reviewed
Oct 31, 2019
JLHwung
approved these changes
Nov 9, 2019
Contributor
|
CI error is unrelated. |
Member
|
Thanks! |
This was referenced Dec 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaceWithMultiple()first sets the node to replace to null then add the new nodes after it throughinsertAfter().insertAfter()already checks for when the node is aJSXElementso that it proceeds to inserting the new nodes to the container. To fix the issue, we want to also check if the parent is aJSXElement.