[parser] Parse only modifiers of actual methods#10594
Merged
nicolo-ribaudo merged 2 commits intobabel:masterfrom Oct 29, 2019
zant:bugfix/optional-async-error
Merged
[parser] Parse only modifiers of actual methods#10594nicolo-ribaudo merged 2 commits intobabel:masterfrom zant:bugfix/optional-async-error
nicolo-ribaudo merged 2 commits intobabel:masterfrom
zant:bugfix/optional-async-error
Conversation
JLHwung
reviewed
Oct 23, 2019
JLHwung
approved these changes
Oct 29, 2019
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
Nice work!
The CI error is unrelated.
Contributor
|
@gonzarodriguezt Could you rebase on master? |
Contributor
Author
|
@JLHwung Sorry i was afk! It's a pleasure @nicolo-ribaudo 🙂 |
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i've did what in my opinion was the most trivial solution and added a test as an start point, reviews are highly appreciated