Skip to content

fix(babel‑helpers/interopRequireWildcard): Avoid double nullish check#10585

Merged
nicolo-ribaudo merged 2 commits intobabel:masterfrom
EB-Forks:fix/babel-helpers/interop-require-wildcard/avoid-double-nullish-check
Oct 24, 2019
Merged

fix(babel‑helpers/interopRequireWildcard): Avoid double nullish check#10585
nicolo-ribaudo merged 2 commits intobabel:masterfrom
EB-Forks:fix/babel-helpers/interop-require-wildcard/avoid-double-nullish-check

Conversation

@ExE-Boss
Copy link
Copy Markdown
Contributor

@ExE-Boss ExE-Boss commented Oct 22, 2019

Q                       A
Fixed Issues? Probably none
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Not yet
Documentation PR Link No
Any Dependency Changes? No
License MIT

This avoids the double‑nullish check in interopRequireWildcard, since undefined and null are already covered by #10574.

@JLHwung
Copy link
Copy Markdown
Contributor

JLHwung commented Oct 22, 2019

Could you run OVERWRITE=true make test-only to overwrite the test fixtures?

@nicolo-ribaudo nicolo-ribaudo added PR: Performance 🏃‍♀️ A type of pull request used for our changelog categories PR: Polish 💅 A type of pull request used for our changelog categories and removed PR: Performance 🏃‍♀️ A type of pull request used for our changelog categories labels Oct 22, 2019
@ExE-Boss
Copy link
Copy Markdown
Contributor Author

I’m unable to do that for whatever reason, even with WSL.

Probably because I’m on Windows and I have a weird setup or something.

@nicolo-ribaudo
Copy link
Copy Markdown
Member

@ExE-Boss Could you enable the "Allow edits from maintainers." at the bottom of the left sidebar here on GitHub? Then I can push the fixtures updates.

@ExE-Boss
Copy link
Copy Markdown
Contributor Author

I have it enabled, but GitHub has bugs with forks on organisations.

@JLHwung
Copy link
Copy Markdown
Contributor

JLHwung commented Oct 24, 2019

@ExE-Boss I have updated the test fixtures. Could you run

git remote add JLHwung https://github.com/JLHwung/babel
git fetch JLHwung
git reset --hard JLHwung/fix/babel-helpers/interop-require-wildcard/avoid-double-nullish-check
git push --force origin fix/babel-helpers/interop-require-wildcard/avoid-double-nullish-check
git remote rm JLHwung

on your working branch?

@ExE-Boss ExE-Boss force-pushed the fix/babel-helpers/interop-require-wildcard/avoid-double-nullish-check branch from 8b938bf to fd36a1d Compare October 24, 2019 05:07
@nicolo-ribaudo nicolo-ribaudo force-pushed the fix/babel-helpers/interop-require-wildcard/avoid-double-nullish-check branch from fd36a1d to da1ea26 Compare October 24, 2019 15:14
@nicolo-ribaudo nicolo-ribaudo merged commit 43065a9 into babel:master Oct 24, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the fix/babel-helpers/interop-require-wildcard/avoid-double-nullish-check branch October 24, 2019 21:14
@nicolo-ribaudo
Copy link
Copy Markdown
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants