[parser] Allow optional async methods#10582
Merged
nicolo-ribaudo merged 2 commits intobabel:masterfrom Nov 18, 2019
zant:bugfix/10525
Merged
[parser] Allow optional async methods#10582nicolo-ribaudo merged 2 commits intobabel:masterfrom zant:bugfix/10525
nicolo-ribaudo merged 2 commits intobabel:masterfrom
zant:bugfix/10525
Conversation
JLHwung
approved these changes
Oct 21, 2019
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
This PR also reveals an issue in modifiers parsing. i.e. the following snippet
class B { }
class A extends B {
async? method(val: string): Promise<void>;
}is expected to throw but currently it is parsed as an optional async method signature. We could address it in a separate PR, though.
Contributor
Author
|
Oh that's right @JLHwung I'll be glad to work on a follow-up PR for that 👍 |
existentialism
approved these changes
Nov 18, 2019
This was referenced Dec 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
async methods were not parsing post member name modifiers, causing
?to be an unexpected token