E2E test Babel with itself before publishing#10569
Merged
nicolo-ribaudo merged 2 commits intobabel:masterfrom Nov 12, 2019
Merged
E2E test Babel with itself before publishing#10569nicolo-ribaudo merged 2 commits intobabel:masterfrom
nicolo-ribaudo merged 2 commits intobabel:masterfrom
Conversation
260352b to
dd4a7d0
Compare
29b1b8c to
3ba482d
Compare
fe0740a to
4c39153
Compare
JLHwung
approved these changes
Nov 11, 2019
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
LGTM on the ci config and integration test scripts.
68d0598 to
8f498d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a CircleCI workflow which
verdaccioregistry@babel/*versions used by our repo, so that it uses the new "published" versionI created the workflow as two separate jobs so that if we decide to add other e2e tests (e.g.
create-react-app,istanbul, ...) we can run them in parallel after "publishing" Babel only once.I initially planned to only run these tests using a cronjob once a day, but since it only takes 7 minutes and it's run in parallel with all the other Travis/Circle tests, we could always run it.
This will probably need to change when we add other e2e tests.
The😄Introduce a bugcommit is an example of a bug which isn't caught by our unit tests but which fails the e2e test