fix: remove filename annotation in buildCodeFrameError#10539
Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom Oct 14, 2019
Merged
fix: remove filename annotation in buildCodeFrameError#10539nicolo-ribaudo merged 1 commit intobabel:masterfrom
nicolo-ribaudo merged 1 commit intobabel:masterfrom
Conversation
nicolo-ribaudo
approved these changes
Oct 13, 2019
existentialism
approved these changes
Oct 14, 2019
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we remove filename annotation on
buildCodeFrameErrorbecauserunSyncwill add filename annotationbuildCodeFrameErroris only used in the plugin visitors, which is executed in the transform phase.This PR does not introduce breaking changes because both
buildCodeFrameErrorandrunSyncare in babel-core.