Do not hoist jsx referencing a mutable binding#10529
Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom Oct 8, 2019
Merged
Do not hoist jsx referencing a mutable binding#10529nicolo-ribaudo merged 1 commit intobabel:masterfrom
nicolo-ribaudo merged 1 commit intobabel:masterfrom
Conversation
existentialism
approved these changes
Oct 8, 2019
hzoo
approved these changes
Oct 8, 2019
jridgewell
reviewed
Oct 8, 2019
|
|
||
| // we can handle reassignments only if they happen in the same scope as the declaration | ||
| for (const violation of binding.constantViolations) { | ||
| if (violation.scope !== binding.path.scope) { |
Member
There was a problem hiding this comment.
Can't we still hoist to the level of the violation?
let foo = 'hello';
export const Component = () => {
foo = 'goodbye';
return <span>{array.map(() => <inner>{foo}</inner>}</span>;
};
Member
Author
There was a problem hiding this comment.
No, we can't. Consider this example:
let foo = 0;
export const Component = () => {
foo++;
return Promise.resolve().then(() => <span>{foo}</span>);
};
Component();
Component();Here both the components should use 2, but if we hoist it the first one will use 1.
jridgewell
approved these changes
Oct 8, 2019
This was referenced Oct 22, 2019
This was referenced Nov 12, 2019
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related tests: