Add declarations for more of @babel/types exports#10504
Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom Oct 8, 2019
Merged
Add declarations for more of @babel/types exports#10504nicolo-ribaudo merged 1 commit intobabel:masterfrom
nicolo-ribaudo merged 1 commit intobabel:masterfrom
Conversation
Jessidhia
commented
Sep 27, 2019
| ); | ||
| } | ||
|
|
||
| lines.push( |
Member
Author
There was a problem hiding this comment.
I think this whole thing would be much nicer to modify if there was, say, a typescript.template.d.ts file that is complete enough to be typechecked and with placeholder comments / types for where the generated types should get injected; the generator script then just needs to slurp the template and edit it.
It'd also get us prettier for free.
937a656 to
b60ec41
Compare
This adds lots of missing declarations to the types of @babel/types, including many utility functions useful to plugin authors. With the typescript types, I tried to make them as useful as possible for control flow analysis / inference, but Flow doesn't seem to support overloads and I'm not as familiar with it anyway so it has simpler types.
b60ec41 to
6e8ad67
Compare
Member
Author
|
CircleCI's build failed.... because it ran out of memory? o_O |
Member
|
Yeah it's flaky |
Jessidhia
commented
Oct 7, 2019
|
|
||
| lines.push( | ||
| `export function is${typeName}(node: object | null | undefined, opts?: object | null): ${result};`, | ||
| // TypeScript 3.7: https://github.com/microsoft/TypeScript/pull/32695 will allow assert declarations |
Member
Author
There was a problem hiding this comment.
We can use typesVersions to publish typings for typescript <3.7 and typescript >=3.7 at the same time, but we'll need to generate types twice.
I want to refactor the typescript generation to use .d.ts files as templates (to make it much easier to get editor feedback while modifying them) so I can try to do that at the same time.
nicolo-ribaudo
approved these changes
Oct 8, 2019
This was referenced Oct 22, 2019
This was referenced Nov 12, 2019
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds lots of missing declarations to the types of @babel/types,
including many utility functions useful to plugin authors.
With the typescript types, I tried to make them as useful as possible
for control flow analysis / inference, but Flow doesn't seem to
support overloads and I'm not as familiar with it anyway so it has
simpler types.