Skip to content

Enable optional chaining and nullish coalescing plugins#10494

Merged
nicolo-ribaudo merged 2 commits intobabel:masterfrom
nicolo-ribaudo:optional-chaining-enable
Sep 24, 2019
Merged

Enable optional chaining and nullish coalescing plugins#10494
nicolo-ribaudo merged 2 commits intobabel:masterfrom
nicolo-ribaudo:optional-chaining-enable

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo commented Sep 24, 2019

Q                       A
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

They are both stage 3, and they are used in a few PRs (e.g. #10491, #10357)

@nicolo-ribaudo nicolo-ribaudo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Sep 24, 2019
@nicolo-ribaudo nicolo-ribaudo changed the title Enable optional chaining and nullish coaleshing plugins Enable optional chaining and nullish coalescing plugins Sep 24, 2019
@nicolo-ribaudo nicolo-ribaudo force-pushed the optional-chaining-enable branch from 67a390a to aae8e3b Compare September 24, 2019 20:40
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Sep 24, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11694/

1 similar comment
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Sep 24, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11694/

hzoo
hzoo approved these changes Sep 24, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Should we add these to preset-env shippedProposals eventually? Not sure how many people are using that anyway though

@nicolo-ribaudo
Copy link
Copy Markdown
Member Author

nicolo-ribaudo commented Sep 24, 2019

Well, they aren't shipped anywhere yet 😛

https://kangax.github.io/compat-table/esnext/#test-optional_chaining_operator_(?.)

@nicolo-ribaudo nicolo-ribaudo merged commit eaa1474 into babel:master Sep 24, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the optional-chaining-enable branch September 24, 2019 21:11
@mrtnzlml
Copy link
Copy Markdown

mrtnzlml commented Oct 10, 2019

@nicolo-ribaudo It's also a good idea to enable this lint rule to make sure it's used correctly: unnecessary-optional-chain

Just a small tip 🍻 :)

This was referenced Oct 22, 2019
Merged
Open
@snyk-bot snyk-bot mentioned this pull request Nov 1, 2019
Open
@jsg2021
Copy link
Copy Markdown

jsg2021 commented Nov 8, 2019 •
edited
Loading

Nice! Should we add these to preset-env shippedProposals eventually? Not sure how many people are using that anyway though

@hzoo I use shippedProposals 😉

@nicolo-ribaudo
Copy link
Copy Markdown
Member Author

nicolo-ribaudo commented Nov 8, 2019

Spoiler: given that we release a new minor about every 2 months, probably shippedProposals won't be the correct place for at least one of them 😉

This was referenced Nov 12, 2019
Open
Merged
This was referenced Nov 28, 2019
Open
Open
This was referenced Dec 5, 2019
Open
Merged
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 8, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hzoo hzoo hzoo approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolo-ribaudo @babel-bot @mrtnzlml @jsg2021 @hzoo