[parser] Disallow numeric separators in legacy octal like integers#10493
Merged
nicolo-ribaudo merged 4 commits intobabel:masterfrom Sep 24, 2019
zant:invalid-lol
Merged
[parser] Disallow numeric separators in legacy octal like integers#10493nicolo-ribaudo merged 4 commits intobabel:masterfrom zant:invalid-lol
nicolo-ribaudo merged 4 commits intobabel:masterfrom
zant:invalid-lol
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11702/ |
packages/babel-parser/test/fixtures/experimental/numeric-separator/invalid-lol/input.js
Show resolved
Hide resolved
added 2 commits
September 24, 2019 18:06
Contributor
Author
|
Thanks to you! Super glad to contribute :) |
JLHwung
approved these changes
Sep 24, 2019
This was referenced Oct 22, 2019
This was referenced Nov 12, 2019
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The follow code should throw an error if the numeric separator plugin is enabled:
Input Code
00_0Expected behavior/code
It should throw Invalid
Invalid numeric separator after leading 0error.The Legacy Octal Like Decimal is defined as:
Reference