Skip to content

[parser] Add support for private fields in TypeScript#10483

Merged
nicolo-ribaudo merged 2 commits intobabel:masterfrom
nicolo-ribaudo:ts-private-fields
Oct 29, 2019
Merged

[parser] Add support for private fields in TypeScript#10483
nicolo-ribaudo merged 2 commits intobabel:masterfrom
nicolo-ribaudo:ts-private-fields

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo commented Sep 23, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This implements microsoft/TypeScript#30829 / microsoft/TypeScript#33509. This PR also supports parsing static fields, which is not suppoerted by the TypeScript PR yet.

cc @babel/typescript

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: parser area: typescript labels Sep 23, 2019
@nicolo-ribaudo nicolo-ribaudo added this to the TypeScript 3.7 milestone Sep 23, 2019
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Sep 23, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11659/

@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Sep 30, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit 1d1fab4 into babel:master Oct 29, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the ts-private-fields branch October 29, 2019 17:27
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 28, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release Spec: Class Fields

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants