added check to disallow super.private variable access and test case added#10472
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11629/ |
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Travis CI is failing, but for a good reason. We test @babel/parser with Test262 (the official ECMAScript tests) and with the official flow tests.
Since we aren't 100% spec compliant yet, we have a whitelist file of tests which are allowed to fail.
This PR made some tests which were previously failing pass, so they should be removed from the whitelist.
You can run make bootstrap-flow and make bootstrap-test262 to download the test suites, and make test-flow-update-whitelist and make test-test262-update-whitelist to update them.
| ) { | ||
| this.raise( | ||
| startPos, | ||
| "super is not allowed to be called on a private identifier of a class", |
There was a problem hiding this comment.
Well, in this case super is not being called (it's not super(#x)).
What about Private fields can't be accessed on super?
There was a problem hiding this comment.
Yes that message makes more sense. I will make the changes accordingly and also update the tests. Thank you
|
@nicolo-ribaudo when I am doing I get the following error: Any help here? |
|
Could you try running |
|
That did the trick. Thank you 👍 |
…ses from whitelist of flow and test 262 suite
Uh oh!
There was an error while loading. Please reload this page.