[parser] Disallow static fields named constructor#10461
Merged
nicolo-ribaudo merged 3 commits intobabel:masterfrom Sep 17, 2019
Merged
[parser] Disallow static fields named constructor#10461nicolo-ribaudo merged 3 commits intobabel:masterfrom
constructor#10461nicolo-ribaudo merged 3 commits intobabel:masterfrom
Conversation
- Disallowed static fields named `constructor` in a class (previously only non-static were disallowed)
- Updated the text for the error for one consolidated warning, for both static and non-static fields
- Added a test
- Updated an existing test in the `flow` test suite of the parser to reflect the parse error.
Strangely, the test used to pass and started failing when inlining the `isNonstaticConstructor` method, without any changes.
In that test, `constructor` was a field, so in theory it should never have passed.
Would appreciate some feedback on this, as I'm not 100% sure if this is somehow related to Flow
...l-parser/test/fixtures/flow/classes/constructor-override-with-class-prop-plugin/options.json
Show resolved
Hide resolved
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11604/ |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11602/ |
nicolo-ribaudo
approved these changes
Sep 17, 2019
Member
|
Thanks! |
existentialism
approved these changes
Sep 17, 2019
Member
existentialism
left a comment
There was a problem hiding this comment.
Nice work @guywaldman!
This was referenced Oct 3, 2019
This was referenced Oct 22, 2019
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Changes
constructorin a class (previously only non-static were disallowed)flowtest suite of the parser to reflect the parse error (see note below)Note for reviewers:
I updated an existing test in the
flowtest suite of the parser (constructor-override-with-class-prop-plugin) to reflect the parse error. Strangely, the test used to pass and started failing when inlining theisNonstaticConstructormethod, without any changes.In that test,
constructorwas a field, so in theory it should never have passed.The test relies on the
jsx(which is probably unrelated),flowandclassPropertiesplugins.So would appreciate some feedback on this, as I'm not 100% sure if this is somehow related to Flow.