Remove babel polyfill dependency of babel-node#10429
Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom Sep 10, 2019
bdwain:master
Merged
Remove babel polyfill dependency of babel-node#10429nicolo-ribaudo merged 1 commit intobabel:masterfrom bdwain:master
nicolo-ribaudo merged 1 commit intobabel:masterfrom
bdwain:master
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11546/ |
nicolo-ribaudo
approved these changes
Sep 10, 2019
JLHwung
approved these changes
Sep 10, 2019
Member
|
Thanks! |
This was referenced Oct 3, 2019
This was referenced Oct 22, 2019
dword-design
pushed a commit
to dword-design/babel
that referenced
this pull request
Nov 15, 2019
This was referenced Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since babel polyfill is deprecated, I removed the usage of it in babel/node. Instead, I switched it to use core-js@3 and regenerator-runtime (as suggested). Behavior is unchanged.
Note that one test seems to fail when running all tests, but not when running tests only for babel-node with TEST_ONLY. But this happens on the latest master too, so I assume it's unrelated to my change.