Skip to content

chore: remove trim-right dependency#10420

Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom
JLHwung:remove-trim-right-dependency
Sep 10, 2019
Merged

chore: remove trim-right dependency#10420
nicolo-ribaudo merged 1 commit intobabel:masterfrom
JLHwung:remove-trim-right-dependency

Conversation

@JLHwung
Copy link
Copy Markdown
Contributor

@JLHwung JLHwung commented Sep 9, 2019

Q                       A
Fixed Issues? remove trim-right and lodash/trimEnd dependencies
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?
Documentation PR Link
Any Dependency Changes? remove trim-right and lodash/trimEnd dependencies
License MIT

String.prototype.trimRight is supported on node >= 6.5: http://kangax.github.io/compat-table/es2016plus/

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Sep 9, 2019
@babel-bot
Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11528/

Copy link
Copy Markdown
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yess less deps 👍 and using JS!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants