Use "validateLogs" for preset-env's debug fixtures#10401
Merged
nicolo-ribaudo merged 2 commits intobabel:masterfrom Sep 6, 2019
Merged
Use "validateLogs" for preset-env's debug fixtures#10401nicolo-ribaudo merged 2 commits intobabel:masterfrom
nicolo-ribaudo merged 2 commits intobabel:masterfrom
Conversation
existentialism
approved these changes
Sep 6, 2019
Member
existentialism
left a comment
There was a problem hiding this comment.
Awesome, been on the list from when we first wrote preset-env :)
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11479/ |
JLHwung
approved these changes
Sep 6, 2019
This was referenced Sep 17, 2019
This was referenced Oct 3, 2019
This was referenced Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes preset-env's
debug-fixturesuse the new functionality introduced in #10326This has two main advantages:
Details
time yarn jest preset-envbefore this PR:time yarn jest preset-envafter this PR:time yarn jestbefore this PR:time yarn jestafter this PR:NOTES:
debug-fixturescontained two input files. I split them in two different fixturesSuccessfully compiled 1 file with Babel.disappeared fromstdout, because it wasn't printed bypreset-envbut by@babel/clioptions.jsonorstdout.txtfiles are reported as "new" or "deleted" by git. It's just because of the fixtures I duplicated, or because git doesn't properly track renames of small files with many updates.