Skip to content

Fix #8326, add back --quiet option.#10399

Merged
nicolo-ribaudo merged 3 commits intobabel:masterfrom
chris-peng-1244:master
Oct 29, 2019
Merged

Fix #8326, add back --quiet option.#10399
nicolo-ribaudo merged 3 commits intobabel:masterfrom
chris-peng-1244:master

Conversation

@chris-peng-1244
Copy link
Copy Markdown
Contributor

@chris-peng-1244 chris-peng-1244 commented Sep 6, 2019 •
edited by JLHwung
Loading

Q                       A
Fixed Issues? Fixes #8326
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link babel/website#3174
Any Dependency Changes?
License MIT

I added the --quiet to the babel-cli which overrides the --verbose option.

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Sep 6, 2019 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11519/

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Sep 6, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11476/

nicolo-ribaudo
nicolo-ribaudo reviewed Sep 6, 2019
View reviewed changes
packages/babel-cli/src/babel/dir.js Outdated
util.chmod(src, dest);

if (cliOptions.verbose) {
if (cliOptions.verbose && !cliOptions.quiet) {
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo Sep 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to throw if both are enabled

Copy link
Copy Markdown
Contributor Author

@chris-peng-1244 chris-peng-1244 Sep 9, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolo-ribaudo Will work on it.

@nicolo-ribaudo nicolo-ribaudo added pkg: cli PR: New Feature 🚀 A type of pull request used for our changelog categories labels Sep 6, 2019
@nicolo-ribaudo nicolo-ribaudo added this to the v7.7.0 milestone Sep 9, 2019
@nicolo-ribaudo
Copy link
Copy Markdown
Member

nicolo-ribaudo commented Sep 9, 2019

Thanks! We will merge this PR when releasing Babel 7.7.0

@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Sep 9, 2019
@chris-peng-1244
Copy link
Copy Markdown
Contributor Author

chris-peng-1244 commented Sep 9, 2019

Glad I managed to contribute!

@woodcockjosh
Copy link
Copy Markdown

woodcockjosh commented Oct 16, 2019

this is so annoying

@nicolo-ribaudo nicolo-ribaudo merged commit 4e5ac1f into babel:master Oct 29, 2019
@danielhaim1
Copy link
Copy Markdown

danielhaim1 commented Nov 3, 2019

Don't forget to add --quiet back to docs

@snyk-bot snyk-bot mentioned this pull request Nov 14, 2019
Merged
This was referenced Nov 28, 2019
Open
Open
This was referenced Dec 5, 2019
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2020
Open
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: cli PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release

Projects

None yet

Milestone

v7.7.0

Development

Successfully merging this pull request may close these issues.

@babel/cli can't be quietened

6 participants

@chris-peng-1244 @babel-bot @nicolo-ribaudo @woodcockjosh @danielhaim1 @JLHwung