Skip to content

Don't polyfill when evaluation is not confident#10397

Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom
rhyzx:patch-2
Sep 5, 2019
Merged

Don't polyfill when evaluation is not confident#10397
nicolo-ribaudo merged 1 commit intobabel:masterfrom
rhyzx:patch-2

Conversation

@rhyzx
Copy link
Copy Markdown
Contributor

@rhyzx rhyzx commented Sep 5, 2019

Q                       A
Fixed Issues? N/A
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

usage/corejs2 will still polyfill if evaluation of property name is not confident,
while corejs3 does not have this bug.

Input:

Object[values]();

Before output:

import "core-js/modules/es6.object.to-string";
import "core-js/modules/es7.object.values";
Object[values]();

After output:

Object[values]();

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Sep 5, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11469/

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: preset-env labels Sep 5, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit 5c859b1 into babel:master Sep 5, 2019
This was referenced Sep 17, 2019
Closed
Closed
Open
Open
Open
This was referenced Oct 3, 2019
Open
Open
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 24, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 1, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 12, 2019
Open
This was referenced Nov 28, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhyzx @babel-bot @existentialism @JLHwung @nicolo-ribaudo