fix: transform name capturing regex once#10395
Merged
nicolo-ribaudo merged 4 commits intobabel:masterfrom Sep 5, 2019
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11462/ |
Member
|
What about using |
Contributor
Author
|
@nicolo-ribaudo Good idea, I revise your suggested regex to include both positive and negative lookbehind. |
nicolo-ribaudo
approved these changes
Sep 5, 2019
existentialism
approved these changes
Sep 5, 2019
This was referenced Sep 17, 2019
This was referenced Oct 3, 2019
This was referenced Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
runtime && !isRegExpTest(path)is true, a new RegExp node will be inserted to AST and visited later by thetransform-named-capturing-groups-regexagain. Most of cases when regex consists of only named capturing groups, the transformed regex node will be prevented byindexOf("(?<")early return, however when there is a lookbehind<?=, babylon will recurse infinitely.Here we revise
indexOf("(?<")early return by looking ahead(?<to see if it is a lookbehind pattern.